Skip to content

rook-ceph: Pin rook ceph image to v1.16.6 #1420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

rook-ceph: Pin rook ceph image to v1.16.6 #1420

wants to merge 1 commit into from

Conversation

brianmcarey
Copy link
Member

What this PR does / why we need it:

Using the master tag for rook can led to changes breaking the deployment of ceph in kubevirtci

Such as the recent rbac issues:
#1416

Pin the rook image to v1.16.6 and use the image that is mirrored to the kubevirtci quay repo

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

/cc @akalenyu @dhiller

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note:

@brianmcarey
rook-ceph: Pin rook ceph image to v1.16.6
b033286 
Using the `master` tag for rook can led to changes breaking the
deployment of ceph in kubevirtci

Such as the recent rbac issues:
kubevirt#1416

Pin the rook image to v1.16.6 and use the image that is mirrored to the
kubevirtci quay repo

Signed-off-by: Brian Carey <[email protected]>
@kubevirt-bot kubevirt-bot requested review from akalenyu and dhiller April 8, 2025 10:03
@kubevirt-bot kubevirt-bot added the dco-signoff: yes Indicates the PR's author has DCO signed all their commits. label Apr 8, 2025
@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign stu-gott for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

dhiller
dhiller reviewed Apr 8, 2025
View reviewed changes
cluster-provision/gocli/opts/rookceph/manifests/operator.yaml
@@ -600,7 +600,7 @@ spec:
serviceAccountName: rook-ceph-system
containers:
- name: rook-ceph-operator
image: docker.io/rook/ceph:master
image: quay.io/kubevirtci/rook-ceph:v1.16.6
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this not create problems whenever people are updating to newer versions - meaning they have to be aware that we are actually mirroring the image to our own registry?

maybe we could try something as patching the yaml with kustomize? This way we could just replace the original yaml with the newer one and the customization would be taken care of when applying it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would not be straight forward as gocli applies the yamls - I am not sure we should add an extra step with kustomize.

I could probably change the image using some regex in gocli but then the actual image that is used is hidden away in gocli - having the image here in the manifests is clear for anyone who needs to find it.

@kubevirt-bot
Copy link
Contributor

kubevirt-bot commented Apr 8, 2025 •
edited
Loading

@brianmcarey: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
check-provision-k8s-1.31-s390x b033286 link false /test check-provision-k8s-1.31-s390x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@brianmcarey
Copy link
Member Author

@sourcery-ai review

@sourcery-ai Sourcery AI
Copy link

sourcery-ai bot commented Apr 10, 2025

Reviewer's Guide by Sourcery

This PR pins the Rook Ceph operator image to version v1.16.6 from the quay.io/kubevirtci repository to ensure a stable deployment and prevent breakages caused by using the master tag. Additionally, it updates the extra-pre-pull-images files for k8s versions 1.30, 1.31, 1.32 and 1.33.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Pin the Rook Ceph operator image to a specific version and update the image source.
  • Changed the Rook Ceph operator image from docker.io/rook/ceph:master to quay.io/kubevirtci/rook-ceph:v1.16.6.
  • This ensures a stable and tested version of Rook Ceph is used, preventing unexpected breakages due to changes in the master tag.
 cluster-provision/gocli/opts/rookceph/manifests/operator.yaml
Update extra pre-pull images files.
  • The extra-pre-pull-images files were updated for k8s versions 1.30, 1.31, 1.32 and 1.33.
 cluster-provision/k8s/1.30/extra-pre-pull-images
cluster-provision/k8s/1.31/extra-pre-pull-images
cluster-provision/k8s/1.32/extra-pre-pull-images
cluster-provision/k8s/1.33/extra-pre-pull-images
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Apr 10, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @brianmcarey - I've reviewed your changes - here's some feedback:

Overall Comments:

  • Consider adding a comment in the code explaining why the rook ceph image is pinned.
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good
Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2025
@brianmcarey
Copy link
Member Author

@sourcery-ai dismiss

@kubevirt-bot
Copy link
Contributor

Pull requests that are marked with lgtm should receive a review
from an approver within 1 week.

After that period the bot marks them with the label needs-approver-review.

/label needs-approver-review

@kubevirt-bot kubevirt-bot added the needs-approver-review Indicates that a PR requires a review from an approver. label Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhiller dhiller dhiller left review comments

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@akalenyu akalenyu akalenyu approved these changes

Assignees

@akalenyu akalenyu

Labels
dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. needs-approver-review Indicates that a PR requires a review from an approver. size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brianmcarey @kubevirt-bot @dhiller @akalenyu